[
https://issues.apache.org/jira/browse/DRILL-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616924#comment-16616924
]
ASF GitHub Bot commented on DRILL-6724:
---------------------------------------
vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator
context to logs when error occurs during query execution
URL: https://github.com/apache/drill/pull/1455#discussion_r217928942
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java
##########
@@ -123,6 +123,21 @@ public void receivingFragmentFinished(final
FragmentHandle handle) {
logger.warn("Currently not handling FinishedFragment message");
}
+ @Override
+ public void dumpOperators() {
+ if (!operators.isEmpty()) {
+ logger.info("Operator dump started.");
+ for (CloseableRecordBatch batch : operators) {
+ batch.dump();
Review comment:
Very much info could be logged. Do we need to dump every batch before failed
batch?
Possibly the only last successfully batch is needed to dump?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Dump operator context to logs when error occurs during query execution
> ----------------------------------------------------------------------
>
> Key: DRILL-6724
> URL: https://issues.apache.org/jira/browse/DRILL-6724
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.14.0
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.15.0
>
>
> Sometimes when an error occurs it may be helpful to have operator stack with
> context data along with original stacktrace to help developers to track down
> a failure. To achieve this, each operator should provide a context which can
> be dumped to logs. In the end of FragmentExecutor's execution if the state is
> FAILED the operator stack will be dumped to logs before exception stacktrace.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
