[
https://issues.apache.org/jira/browse/DRILL-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16629843#comment-16629843
]
ASF GitHub Bot commented on DRILL-6762:
---------------------------------------
Muritiku commented on a change in pull request #1482: DRILL-6762: Dynamic UDFs
registered on 1 Drillbit not visible on others
URL: https://github.com/apache/drill/pull/1482#discussion_r220815606
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/RemoteFunctionRegistry.java
##########
@@ -84,6 +84,7 @@
private static final String registry_path = "registry";
private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(RemoteFunctionRegistry.class);
private static final ObjectMapper mapper = new
ObjectMapper().enable(INDENT_OUTPUT);
+ public static final int UNREACHABLE = Integer.MIN_VALUE;
Review comment:
Maybe better to use long but not int?
Because in that case will be autoconversion in
(FunctionImplementationRegistry.java): "private boolean
isRegistrySyncNeeded(long remoteVersion, long localVersion)"
Just a thought. It is not reccomended in java to compare int and long
directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Dynamic UDFs registered on one Drillbit are not visible on other Drillbits
> --------------------------------------------------------------------------
>
> Key: DRILL-6762
> URL: https://issues.apache.org/jira/browse/DRILL-6762
> Project: Apache Drill
> Issue Type: Bug
> Components: Functions - Drill
> Affects Versions: 1.13.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Critical
> Fix For: 1.15.0
>
> Attachments: Dynamic UDFs issue.pdf
>
>
> Originally Reported :
> https://stackoverflow.com/questions/52480160/dynamic-udf-in-apache-drill-cluster
> When using a 4-node Drill 1.14 cluster, UDF jars registered on one node are
> not usable on other nodes despite the {{/registry}} and ZK showing the UDFs
> as registered.
> This was previously working on 1.13.0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
