[
https://issues.apache.org/jira/browse/DRILL-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645640#comment-16645640
]
ASF GitHub Bot commented on DRILL-3988:
---------------------------------------
kkhatua commented on a change in pull request #1483: DRILL-3988: Expose Drill
built-in functions & UDFs in a system table
URL: https://github.com/apache/drill/pull/1483#discussion_r224263847
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/registry/FunctionRegistryHolderTest.java
##########
@@ -202,26 +250,38 @@ public void testGetAllFunctionsWithSignatures() {
public void testGetHoldersByFunctionNameWithVersion() {
List<DrillFuncHolder> expectedResult = newJars.values().stream()
.flatMap(Collection::stream)
- .filter(f -> "lower".equals(f.getName()))
+ .filter(f -> LOWER_FUNC_NAME.equals(f.getName()))
.map(FunctionHolder::getHolder)
.collect(Collectors.toList());
assertFalse(expectedResult.isEmpty());
AtomicInteger version = new AtomicInteger();
- compareTwoLists(expectedResult,
registryHolder.getHoldersByFunctionName("lower", version));
+ compareTwoLists(expectedResult,
registryHolder.getHoldersByFunctionName(LOWER_FUNC_NAME, version));
assertEquals("Version number should match", version.get(),
registryHolder.getVersion());
}
@Test
public void testGetHoldersByFunctionName() {
- List<DrillFuncHolder> expectedResult = newJars.values().stream()
- .flatMap(Collection::stream)
- .filter(f -> "lower".equals(f.getName()))
- .map(FunctionHolder::getHolder)
- .collect(Collectors.toList());
+ List<DrillFuncHolder> expectedUniqueResult = Lists.newArrayList();
Review comment:
Done. removed all references to Lists and removed the Guava import as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create a sys.functions table to expose available Drill functions
> ----------------------------------------------------------------
>
> Key: DRILL-3988
> URL: https://issues.apache.org/jira/browse/DRILL-3988
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Metadata
> Reporter: Jacques Nadeau
> Assignee: Kunal Khatua
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> Create a new sys.functions table that returns a list of all available
> functions.
> Key considerations:
> - one row per name or one per argument set. I'm inclined to latter so people
> can use queries to get to data.
> - we need to create a delineation between user functions and internal
> functions and only show user functions. 'CastInt' isn't something the user
> should be able to see (or run).
> - should we add a description annotation that could be included in the
> sys.functions table?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
