[
https://issues.apache.org/jira/browse/DRILL-6792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649357#comment-16649357
]
ASF GitHub Bot commented on DRILL-6792:
---------------------------------------
weijietong opened a new pull request #1504: DRILL-6792: Find the right probe
side fragment wrapper & fix DrillBuf…
URL: https://github.com/apache/drill/pull/1504
This PR mainly solves two problems about JPPD:
1. Refactor the logic to find the right probe side fragment wrapper which
contains the `RuntimeFilterPOP` at the physical operator tree.
The reason to do this is that the original implementation logic depends on
`GroupScan`'s digest. But that value maybe changed after being first time
attached to the `RuntimeFilterDef` due to different plugin implementation
logics. Now we generate a unique identifier to represent the `RuntimeFilterPOP`
,attach this identifier to the `RuntimeFilterDef`, find the right probe side
fragment `Wrapper` according to the identifier.
2. Fix BloomFilter's `DrillBuf` reference counter bugs while passing
`RuntimeFilterWritable` between different threads.
The original implementation logic lacks the logic to retain the
`RuntimeFilterWritable` underlying DrillBuf reference count while the receiving
thread received it.
@sohami @amansinha100 please review it, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Find the right probe side fragment to any storage plugin
> --------------------------------------------------------
>
> Key: DRILL-6792
> URL: https://issues.apache.org/jira/browse/DRILL-6792
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Flow
> Reporter: weijie.tong
> Assignee: weijie.tong
> Priority: Major
> Fix For: 1.15.0
>
>
> The current implementation of JPPD to find the probe side wrapper depends on
> the GroupScan's digest. But there's no promise the GroupScan's digest will
> not be changed since it is attached to the RuntimeFilterDef by different
> storage plugin implementation logic.So here we assign a unique identifier to
> the RuntimeFilter operator, and find the right probe side fragment wrapper by
> the runtime filter identifier at the RuntimeFilterRouter class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
