[ https://issues.apache.org/jira/browse/DRILL-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660373#comment-16660373 ]
ASF GitHub Bot commented on DRILL-6715: --------------------------------------- vvysotskyi commented on a change in pull request #1507: DRILL-6715: Update descriptions for System Options table URL: https://github.com/apache/drill/pull/1507#discussion_r227318241 ########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ########## @@ -287,20 +303,21 @@ private ExecConstants() { PARQUET_WRITER_ENABLE_DICTIONARY_ENCODING, new OptionDescription("For internal use. Do not change.")); - public static final String PARQUET_WRITER_USE_PRIMITIVE_TYPES_FOR_DECIMALS - = "store.parquet.writer.use_primitive_types_for_decimals"; - public static final OptionValidator PARQUET_WRITER_USE_PRIMITIVE_TYPES_FOR_DECIMALS_VALIDATOR = new BooleanValidator( - PARQUET_WRITER_USE_PRIMITIVE_TYPES_FOR_DECIMALS, null); + public static final String PARQUET_WRITER_USE_PRIMITIVE_TYPES_FOR_DECIMALS = "store.parquet.writer.use_primitive_types_for_decimals"; + public static final OptionValidator PARQUET_WRITER_USE_PRIMITIVE_TYPES_FOR_DECIMALS_VALIDATOR = new BooleanValidator(PARQUET_WRITER_USE_PRIMITIVE_TYPES_FOR_DECIMALS, + new OptionDescription("Instructs the Parquet writer to convert decimal to primitive types whenever possible.")); - public static final String PARQUET_WRITER_LOGICAL_TYPE_FOR_DECIMALS - = "store.parquet.writer.logical_type_for_decimals"; - public static final OptionValidator PARQUET_WRITER_LOGICAL_TYPE_FOR_DECIMALS_VALIDATOR - = new EnumeratedStringValidator(PARQUET_WRITER_LOGICAL_TYPE_FOR_DECIMALS, null, "fixed_len_byte_array", "binary"); + public static final String PARQUET_WRITER_LOGICAL_TYPE_FOR_DECIMALS = "store.parquet.writer.logical_type_for_decimals"; + public static final OptionValidator PARQUET_WRITER_LOGICAL_TYPE_FOR_DECIMALS_VALIDATOR = new EnumeratedStringValidator(PARQUET_WRITER_LOGICAL_TYPE_FOR_DECIMALS, + new OptionDescription("Parquet writer logical type for decimal; supported types \'fixed_len_byte_array\' and \'binary\'"), + "fixed_len_byte_array", "binary"); + // TODO - The below two options don't seem to be used in the Drill code base Review comment: Then it would be good to add `OptionDescription`s for these options and point there that they are deprecated and will be removed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update descriptions for System Options table > -------------------------------------------- > > Key: DRILL-6715 > URL: https://issues.apache.org/jira/browse/DRILL-6715 > Project: Apache Drill > Issue Type: Improvement > Components: Web Server > Affects Versions: 1.14.0 > Reporter: Kunal Khatua > Assignee: Kunal Khatua > Priority: Major > Fix For: 1.15.0 > > > With introduction of DRILL-5735 , the descriptions for about half the system > options still remain missing. > This Jira is to track that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)