[jira] [Commented] (DRILL-6798) Planner changes to support semi-join

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669050#comment-16669050
 ] 

ASF GitHub Bot commented on DRILL-6798:
---------------------------------------

amansinha100 commented on a change in pull request #1514: DRILL-6798: Planner 
changes to support semi-join.
URL: https://github.com/apache/drill/pull/1514#discussion_r229378653
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/JoinPrel.java
 ##########
 @@ -139,4 +158,57 @@ protected void buildJoinConditions(List<JoinCondition> 
conditions,
     }
   }
 
+  public boolean isSemiJoin() {
+    return isSemiJoin;
+  }
+
+  @Override public boolean isValid(Litmus litmus, Context context) {
 
 Review comment:
   Pls add comments about why this function had to be duplicated from the base 
class and what change was needed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Planner changes to support semi-join
> ------------------------------------
>
>                 Key: DRILL-6798
>                 URL: https://issues.apache.org/jira/browse/DRILL-6798
>             Project: Apache Drill
>          Issue Type: Sub-task
>          Components: Query Planning &amp; Optimization
>    Affects Versions: 1.14.0
>            Reporter: Boaz Ben-Zvi
>            Assignee: Hanumath Rao Maduri
>            Priority: Major
>             Fix For: 1.15.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)