[
https://issues.apache.org/jira/browse/DRILL-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673204#comment-16673204
]
ASF GitHub Bot commented on DRILL-5671:
---------------------------------------
bitblender commented on a change in pull request #1467: DRILL-5671: Set secure
ACLs (Access Control List) for Drill ZK nodes in a secure cluster
URL: https://github.com/apache/drill/pull/1467#discussion_r230403657
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKACLProviderFactory.java
##########
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.coord.zk;
+
+import org.apache.drill.common.config.DrillConfig;
+import static org.apache.drill.exec.ExecConstants.ZK_ACL_PROVIDER;
+import static org.apache.drill.exec.ExecConstants.ZK_APPLY_SECURE_ACL;
+
+import org.apache.drill.common.scanner.persistence.ScanResult;
+import org.apache.drill.exec.exception.DrillbitStartupException;
+import org.apache.drill.exec.server.BootStrapContext;
+import org.apache.drill.shaded.guava.com.google.common.base.Strings;
+import java.lang.reflect.InvocationTargetException;
+
+import java.lang.reflect.Constructor;
+import java.util.Collection;
+
+/**
+ * This function returns a {@link ZKACLProviderDelegate} which will be used to
set ACLs on Drill ZK nodes
+ * If secure ACLs are required, the {@link ZKACLProviderFactory} looks up and
instantiates a {@link ZKACLProviderDelegate}
+ * specified in the config file. Else it returns the {@link
ZKDefaultACLProvider}
+ */
+public class ZKACLProviderFactory {
+
+ static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(ZKACLProviderFactory.class);
+
+ public static ZKACLProviderDelegate getACLProvider(DrillConfig config,
String drillClusterPath, BootStrapContext context)
+ throws DrillbitStartupException {
+ ZKACLContextProvider stateProvider = new
ZKACLContextProviderImpl(drillClusterPath);
+
+ if (config.getBoolean(ZK_APPLY_SECURE_ACL)) {
+ logger.trace("Using secure ZK ACL. Drill cluster path " +
drillClusterPath);
+ ZKACLProviderDelegate aclProvider = findACLProvider(config,
stateProvider, context);
+ return aclProvider;
+ }
+ logger.trace("Using un-secure default ZK ACL");
+ final ZKDefaultACLProvider defaultAclProvider = new
ZKDefaultACLProvider(stateProvider);
+ return new ZKACLProviderDelegate(defaultAclProvider);
+ }
+
+ public static ZKACLProviderDelegate findACLProvider(DrillConfig config,
ZKACLContextProvider contextProvider,
+ BootStrapContext
context) throws DrillbitStartupException {
+ if (!config.hasPath(ZK_ACL_PROVIDER)) {
+ throw new DrillbitStartupException(String.format("BOOT option '%s'
is missing in config.", ZK_ACL_PROVIDER));
+ }
+
+ final String aclProviderName = config.getString(ZK_ACL_PROVIDER);
+
+ if (Strings.isNullOrEmpty(aclProviderName)) {
+ throw new DrillbitStartupException(String.format("Invalid value
'%s' for BOOT option '%s'", aclProviderName,
+ ZK_ACL_PROVIDER));
+ }
+
+ ScanResult scan = context.getClasspathScan();
+ final Collection<Class<? extends ZKACLProvider>> aclProviderImpls =
+ scan.getImplementations(ZKACLProvider.class);
+ logger.debug("Found ZkACLProvider implementations: {}",
aclProviderImpls);
+
+ for (Class<? extends ZKACLProvider> clazz : aclProviderImpls) {
+ final ZKACLProviderTemplate template =
clazz.getAnnotation(ZKACLProviderTemplate.class);
+ if (template == null) {
+ logger.warn("{} doesn't have {} annotation. Skipping.",
clazz.getCanonicalName(),
+ ZKACLProviderTemplate.class);
+ continue;
+ }
+
+ if (template.type().equalsIgnoreCase(aclProviderName)) {
+ Constructor<?> validConstructor = null;
+ Class constructorArgumentClass = ZKACLContextProvider.class;
+ for (Constructor<?> c : clazz.getConstructors()) {
+ Class<?>[] params = c.getParameterTypes();
+ if (params.length == 1 && params[0] == constructorArgumentClass)
{
+ validConstructor = c;
+ break;
+ }
+ }
+ if (validConstructor == null) {
+ logger.warn("Skipping ZKACLProvider implementation class '{}'
since it doesn't " +
+ "implement a constructor [{}({})]",
clazz.getCanonicalName(), clazz.getName(),
+ constructorArgumentClass.getName());
+ continue;
+ }
+ try {
+ final ZKACLProvider aclProvider = (ZKACLProvider)
validConstructor.newInstance(contextProvider);
+ return new ZKACLProviderDelegate(aclProvider);
+ } catch (InvocationTargetException | IllegalArgumentException |
IllegalAccessException | InstantiationException e ) {
Review comment:
Thanks for pointing this out ! Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Set secure ACLs (Access Control List) for Drill ZK nodes in a secure cluster
> ----------------------------------------------------------------------------
>
> Key: DRILL-5671
> URL: https://issues.apache.org/jira/browse/DRILL-5671
> Project: Apache Drill
> Issue Type: New Feature
> Components: Server
> Reporter: Karthikeyan Manivannan
> Assignee: Karthikeyan Manivannan
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> All Drill ZK nodes, currently, are assigned a default [world:all] ACL i.e.
> anyone gets to do CDRWA(create, delete, read, write, admin access). This
> means that even on a secure cluster anyone can perform all CRDWA actions on
> the znodes.
> This should be changed such that:
> - In a non-secure cluster, Drill will continue using the current default
> [world:all] ACL
> - In a secure cluster, all nodes should have an [authid: all] ACL i.e. the
> authenticated user that created the znode gets full access. The discovery
> znodes i.e. the znodes with the list of Drillbits will have an additional
> [world:read] ACL, i.e. the list of Drillbits will be readable by anyone.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
