[
https://issues.apache.org/jira/browse/DRILL-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691878#comment-16691878
]
ASF GitHub Bot commented on DRILL-6850:
---------------------------------------
vvysotskyi commented on a change in pull request #1542: DRILL-6850: JDBC
integration tests failures
URL: https://github.com/apache/drill/pull/1542#discussion_r234632039
##########
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcStoragePlugin.java
##########
@@ -291,27 +292,41 @@ public Table getTable(String name) {
if (table != null) {
return table;
}
- return inner.getTable(name.toUpperCase());
+ if (!areTableNamesCaseSensitive()) {
Review comment:
We can obtain `SqlDialect` for used DB, or use driver, specified in the
config to determine the DB. But the behavior for some BDs may be configured
[1], and I'm not sure that we can receive its values.
I think it will be better to leave it as it is.
[1] https://dev.mysql.com/doc/refman/8.0/en/identifier-case-sensitivity.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> JDBC integration tests failures
> -------------------------------
>
> Key: DRILL-6850
> URL: https://issues.apache.org/jira/browse/DRILL-6850
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - JDBC
> Affects Versions: 1.14.0
> Reporter: Vitalii Diravka
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> The following command will run Drill integratiom tests for RDBMS (Derby and
> MySQL):
> _mvn integration-test failsafe:integration-test -pl contrib/storage-jdbc_
> Currently some drill/exec/store/jdbc TestJdbcPluginWithDerbyIT and
> TestJdbcPluginWithMySQLIT tests fail:
> {code}
> Results :
> Failed tests:
> TestJdbcPluginWithDerbyIT.showTablesDefaultSchema:117 expected:<1> but
> was:<0>
> Tests in error:
> TestJdbcPluginWithDerbyIT.describe » UserRemote VALIDATION ERROR: Unknown
> tabl...
>
> TestJdbcPluginWithDerbyIT.pushdownDoubleJoinAndFilter:111->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:89->PlanTestBase.getPlanInString:369->BaseTestQuery.testSqlWithResults:322->BaseTestQuery.testRunAndReturn:341
> » Rpc
> TestJdbcPluginWithDerbyIT.testCrossSourceMultiFragmentJoin » UserRemote
> VALIDA...
> TestJdbcPluginWithDerbyIT.validateResult:71 » at position 0 column
> '`NUMERIC_...
> TestJdbcPluginWithMySQLIT.validateResult:108 » at position 0 column
> '`numeric...
> Tests run: 14, Failures: 1, Errors: 5, Skipped: 0
> {code}
> Most likely these are old regressions.
> Additionally NPE for empty result is resolved:
> http://drill.apache.org/blog/2018/08/05/drill-1.14-released/#comment-4082559169
> Also, in the scope of this Jira will be allowed configuring table names case
> sensitivity for JDBC storage plugin. Some databases, like derby or postgres
> are case insensitive regarding table names, but other databases like
> mySQL(depending on its configuration) may be case sensitive regarding table
> names. Therefore will be provided a parameter for storage plugin
> {{caseInsensitiveTableNames}} which determines whether table names should be
> handled considering case sensitivity.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
