[
https://issues.apache.org/jira/browse/DRILL-6868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697286#comment-16697286
]
ASF GitHub Bot commented on DRILL-6868:
---------------------------------------
arina-ielchiieva commented on a change in pull request #1553: DRILL-6868:
Upgrade Janino compiler to 3.0.11
URL: https://github.com/apache/drill/pull/1553#discussion_r235974756
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/MethodGrabbingVisitor.java
##########
@@ -64,9 +67,31 @@ public void
traverseClassDeclaration(AbstractClassDeclaration classDeclaration)
@Override
public void traverseMethodDeclarator(MethodDeclarator methodDeclarator) {
if (captureMethods) {
+ // Generate a "labeled statement".
Review comment:
Please add comments inline explaining each action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade Janino compiler to 3.0.11
> ---------------------------------
>
> Key: DRILL-6868
> URL: https://issues.apache.org/jira/browse/DRILL-6868
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.14.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Recently new version 3.0.11 of Janino compiler was released which contains
> fixes for [https://github.com/janino-compiler/janino/issues/61] and
> [https://github.com/janino-compiler/janino/issues/62]. So after the update,
> workarounds for these issues may be removed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
