[
https://issues.apache.org/jira/browse/DRILL-6863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16703286#comment-16703286
]
ASF GitHub Bot commented on DRILL-6863:
---------------------------------------
KazydubB commented on a change in pull request #1557: DRILL-6863: Drop table is
not working if path within workspace starts…
URL: https://github.com/apache/drill/pull/1557#discussion_r237506645
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
##########
@@ -56,7 +57,7 @@ public DropTableHandler(SqlHandlerConfig config) {
@Override
public PhysicalPlan getPlan(SqlNode sqlNode) throws ValidationException,
RelConversionException, IOException {
SqlDropTable dropTableNode = ((SqlDropTable) sqlNode);
- String originalTableName = dropTableNode.getName();
+ String originalTableName =
FileSelection.removeLeadingSlash(dropTableNode.getName());
Review comment:
Actually, this may appear counter-intuitive for users especially when Drill
supports `SELECT` with leading slash (see
[DRILL-1130](https://issues.apache.org/jira/browse/DRILL-1130)). When a table
is created and its name does start with '/' it will be created within
workspace, i.e. will be rooted from the workspace.
You could think of it as if you performed `touch` (on Unix[-like] OS) to
create a file: `touch /${filename}` and `touch ${filename}` should create a
file in the same directory when working directory (workspace) is root ('/').
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Drop table is not working if path within workspace starts with '/'
> ------------------------------------------------------------------
>
> Key: DRILL-6863
> URL: https://issues.apache.org/jira/browse/DRILL-6863
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.15.0
> Reporter: Denys Ordynskiy
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.16.0
>
>
> Drill works incorrectly if path to the table within workspace starts with '/'
> Request "drop table s3.tmp.`drill/transitive_closure/tab1`" works fine,
> but if I add '/' in the begining of the tables path "drop table
> s3.tmp.`{color:#d04437}/{color}drill/transitive_closure/tab1`", Drill is
> trying to find table in the root directory but not in workspace path.
> *Actual result:*
> Drill returns successfully response
> "Table [/drill/transitive_closure/tab1] dropped"
> but table was not dropped.
>
> *Expected result:*
> Table was droped.
> Bug can be reproduced on S3 and DFS storages. On FileSystem storage Drill
> successfully returns error message if "drop table" query starts with '/' in
> table path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
