[
https://issues.apache.org/jira/browse/DRILL-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717177#comment-16717177
]
ASF GitHub Bot commented on DRILL-6895:
---------------------------------------
vdiravka commented on a change in pull request #1571: DRILL-6895: Warnings for
license headers checks and wrong license hea…
URL: https://github.com/apache/drill/pull/1571#discussion_r240615213
##########
File path: distribution/src/resources/drill-conf
##########
@@ -1,19 +1,21 @@
-#!/bin/bash
+#!/usr/bin/env bash
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Warnings for license headers checks and wrong license headers in some files
> ---------------------------------------------------------------------------
>
> Key: DRILL-6895
> URL: https://issues.apache.org/jira/browse/DRILL-6895
> Project: Apache Drill
> Issue Type: Task
> Components: Tools, Build & Test
> Affects Versions: 1.14.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Minor
> Fix For: 1.15.0
>
>
> Drill maven build leverages {{com.mycila:license-maven-plugin:3.0}} to check
> files license headers:
> https://github.com/apache/drill/blob/master/docs/dev/LicenseHeaders.md#doing-license-checks
> But some file extensions in Drill project aren't known for plugin, therefore
> it can't verify the license header for them.
> {code}
> mvn license:check -Dlicense.skip=false
> {code}
> {code}
> ...
> [INFO] --- license-maven-plugin:3.0:check (default) @ drill-root ---
> [INFO] Checking licenses...
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/distribution/src/deb/control/control
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/distribution/src/resources/drill-conf
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/distribution/src/resources/drill-embedded
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/distribution/src/resources/drill-localhost
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/distribution/src/resources/drillbit
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/distribution/src/resources/dumpcat
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/distribution/src/resources/runbit
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/distribution/src/resources/submit_plan
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/distribution/src/resources/sqlline
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/distribution/src/deb/control/conffiles
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/main/sh/runbit
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/regex/baddates.log2
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/regex/simple.log2
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/store/image/1_webp_a.webp
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/store/image/rose-128x174-24bit.pcx
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/store/image/rose-128x174-32bit-alpha.psd
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/store/image/sample.avi
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/store/image/sample.mp4
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/store/image/sample.wav
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/store/pcapng/sniff.pcapng
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/sh/runexec
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/regex/simple.log1
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/regex/mysql.sqllog2
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/regex/mysql.sqllog
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/sh/runbit
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/store/pcapng/example.pcapng
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/exec/java-exec/src/test/resources/store/image/sample.mov
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/logical/src/main/antlr4/org/apache/drill/common/expression/parser/ExprLexer.g4
> [WARNING] Unknown file extension:
> /root/drillAutomation/builds/drill/logical/src/main/antlr4/org/apache/drill/common/expression/parser/ExprParser.g4
> [WARNING] Unable to find a comment style definition for some files. You may
> want to add a custom mapping for the relevant file extensions.
> ...
> {code}
> It is necessary to add these file extensions to the plugin for a custom
> mapping block, specify the type of the license header there and modify
> license headers in the files to correspond the main one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
