[
https://issues.apache.org/jira/browse/DRILL-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800459#comment-16800459
]
ASF GitHub Bot commented on DRILL-7032:
---------------------------------------
arina-ielchiieva commented on pull request #1637: DRILL-7032: Ignore corrupt
rows in a PCAP file
URL: https://github.com/apache/drill/pull/1637#discussion_r268515281
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java
##########
@@ -324,7 +333,12 @@ public int getDst_port() {
byte[] data = null;
if (packetLength >= payloadDataStart) {
data = new byte[packetLength - payloadDataStart];
- System.arraycopy(raw, ipOffset + payloadDataStart, data, 0, data.length);
+ try {
+ System.arraycopy(raw, ipOffset + payloadDataStart, data, 0,
data.length);
+ } catch (Exception e) {
+ isCorrupt = true;
+ logger.info("Error while parsing PCAP data: ", e.getMessage());
Review comment:
I think log info will produce error for each corrupt row and log file can
grow enormously. I guess this should be debug, you can also include trace for
the full exception:
```
String message = "Error while parsing PCAP data: {}";
logger.debug(message, e.getMessage());
logger.trace(message, e);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ignore corrupt rows in a PCAP file
> ----------------------------------
>
> Key: DRILL-7032
> URL: https://issues.apache.org/jira/browse/DRILL-7032
> Project: Apache Drill
> Issue Type: Improvement
> Components: Functions - Drill
> Affects Versions: 1.15.0
> Environment: OS: Ubuntu 18.4
> Drill version: 1.15.0
> Java(TM) SE Runtime Environment (build 1.8.0_191-b12)
> Reporter: Giovanni Conte
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.16.0
>
>
> Would be useful for Drill to have some ability to ignore corrupt rows in a
> PCAP file instead of trow the java exception.
> This is because there are many pcap files with corrupted lines and this
> funcionality will avoid to do a pre-fixing of the packet-captures (example
> attached file).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
