[
https://issues.apache.org/jira/browse/DRILL-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800919#comment-16800919
]
ASF GitHub Bot commented on DRILL-7048:
---------------------------------------
kkhatua commented on pull request #1714: DRILL-7048: Implement JDBC
Statement.setMaxRows() with System Option
URL: https://github.com/apache/drill/pull/1714#discussion_r268772086
##########
File path:
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java
##########
@@ -32,4 +33,25 @@
*/
public interface DrillPreparedStatement extends PreparedStatement {
+ /**
+ * @throws SQLException
+ * Any SQL exception
+ */
+ @Override
+ int getMaxRows() throws SQLException;
Review comment:
I think I was declaring it because it seemed Avatica preferred using
`setLargeMaxRows() / getLargeMaxRows()` . I, anyway, cannot really override
this (all calls to `setMaxRows() / getMaxRows()` are redirected to the
`...Large...` methods), so I'll remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement JDBC Statement.setMaxRows() with System Option
> --------------------------------------------------------
>
> Key: DRILL-7048
> URL: https://issues.apache.org/jira/browse/DRILL-7048
> Project: Apache Drill
> Issue Type: New Feature
> Components: Client - JDBC, Query Planning & Optimization
> Affects Versions: 1.15.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.17.0
>
>
> With DRILL-6960, the webUI will get an auto-limit on the number of results
> fetched.
> Since more of the plumbing is already there, it makes sense to provide the
> same for the JDBC client.
> In addition, it would be nice if the Server can have a pre-defined value as
> well (default 0; i.e. no limit) so that an _admin_ would be able to ensure a
> max limit on the resultset size as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
