[ https://issues.apache.org/jira/browse/DRILL-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802661#comment-16802661 ]
ASF GitHub Bot commented on DRILL-7051: --------------------------------------- vdiravka commented on pull request #1681: DRILL-7051: Upgrade to Jetty 9.3 URL: https://github.com/apache/drill/pull/1681#discussion_r269085173 ########## File path: pom.xml ########## @@ -2553,7 +2548,13 @@ <version>4.0.1</version> <scope>provided</scope> </dependency> - <!--/Javax Servlet dependecies--> + + <dependency> + <groupId>javax.ws.rs</groupId> + <artifactId>javax.ws.rs-api</artifactId> Review comment: This is versions control for `javax` transitive dependencies from `jersey` dependencies, since they are also widely used in Drill. I have updated them to the latest versions along with `jersey` dependencies. But after reading some good practices, I rethought it. It is better to control only `jersey` dependencies. Since `javax.ws` can have an interfaces, which are not implemented in Jersey yet. So I removed this `javax` versions control mechanism ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade to Jetty 9.3 > --------------------- > > Key: DRILL-7051 > URL: https://issues.apache.org/jira/browse/DRILL-7051 > Project: Apache Drill > Issue Type: Improvement > Components: Web Server > Affects Versions: 1.15.0 > Reporter: Veera Naranammalpuram > Assignee: Vitalii Diravka > Priority: Major > Fix For: 1.16.0 > > > Is Drill using a version of jetty web server that's really old? The jar's > suggest it's using jetty 9.1 that was built sometime in 2014? > {noformat} > -rw-r--r-- 1 veeranaranammalpuram staff 15988 Nov 20 2017 > jetty-continuation-9.1.1.v20140108.jar > -rw-r--r-- 1 veeranaranammalpuram staff 103288 Nov 20 2017 > jetty-http-9.1.5.v20140505.jar > -rw-r--r-- 1 veeranaranammalpuram staff 101519 Nov 20 2017 > jetty-io-9.1.5.v20140505.jar > -rw-r--r-- 1 veeranaranammalpuram staff 95906 Nov 20 2017 > jetty-security-9.1.5.v20140505.jar > -rw-r--r-- 1 veeranaranammalpuram staff 401593 Nov 20 2017 > jetty-server-9.1.5.v20140505.jar > -rw-r--r-- 1 veeranaranammalpuram staff 110992 Nov 20 2017 > jetty-servlet-9.1.5.v20140505.jar > -rw-r--r-- 1 veeranaranammalpuram staff 119215 Nov 20 2017 > jetty-servlets-9.1.5.v20140505.jar > -rw-r--r-- 1 veeranaranammalpuram staff 341683 Nov 20 2017 > jetty-util-9.1.5.v20140505.jar > -rw-r--r-- 1 veeranaranammalpuram staff 38707 Dec 21 15:42 > jetty-util-ajax-9.3.19.v20170502.jar > -rw-r--r-- 1 veeranaranammalpuram staff 111466 Nov 20 2017 > jetty-webapp-9.1.1.v20140108.jar > -rw-r--r-- 1 veeranaranammalpuram staff 41763 Nov 20 2017 > jetty-xml-9.1.1.v20140108.jar {noformat} > This version is shown as deprecated: > [https://www.eclipse.org/jetty/documentation/current/what-jetty-version.html#d0e203] > Opening this to upgrade jetty to the latest stable supported version. -- This message was sent by Atlassian JIRA (v7.6.3#76005)