[
https://issues.apache.org/jira/browse/DRILL-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806567#comment-16806567
]
ASF GitHub Bot commented on DRILL-7063:
---------------------------------------
vdiravka commented on pull request #1723: DRILL-7063: Seperate metadata cache
file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r270729791
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/RefreshMetadataHandler.java
##########
@@ -161,7 +161,7 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws
ForemanSetupException {
*/
private SqlNodeList getColumnList(final SqlRefreshMetadata
sqlrefreshMetadata) {
SqlNodeList columnList = sqlrefreshMetadata.getFieldList();
- if (columnList == null || !SqlNodeList.isEmptyList(columnList)) {
Review comment:
`SqlNodeList.isEmptyList(node)` checks `node instanceof SqlNodeList`,
therefore no need to check `columnList == null` explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create separate summary file for schema, totalRowCount, totalNullCount
> (includes maintenance)
> ---------------------------------------------------------------------------------------------
>
> Key: DRILL-7063
> URL: https://issues.apache.org/jira/browse/DRILL-7063
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Metadata
> Reporter: Venkata Jyothsna Donapati
> Assignee: Venkata Jyothsna Donapati
> Priority: Major
> Fix For: 1.16.0
>
> Original Estimate: 252h
> Remaining Estimate: 252h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
