[ https://issues.apache.org/jira/browse/DRILL-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807905#comment-16807905 ]
Abhishek Girish commented on DRILL-7147: ---------------------------------------- [~Paul.Rogers], you are right. With the "simple" way, there is no issue with {{drill-env.sh}} & &{{distrib-env.sh}}. Like you said, setting the simple way in {{drill-env.sh}} could cause issues if corresponding ENV variables are set. And I think that's something we could document instead of finding a fix. > Source order of "drill-env.sh" and "distrib-env.sh" should be swapped > --------------------------------------------------------------------- > > Key: DRILL-7147 > URL: https://issues.apache.org/jira/browse/DRILL-7147 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Flow > Affects Versions: 1.15.0 > Reporter: Hao Zhu > Assignee: Abhishek Girish > Priority: Minor > Fix For: 1.16.0 > > > In bin/drill-config.sh, the description of the source order is: > {code:java} > # Variables may be set in one of four places: > # > # Environment (per run) > # drill-env.sh (per site) > # distrib-env.sh (per distribution) > # drill-config.sh (this file, Drill defaults) > # > # Properties "inherit" from items lower on the list, and may be "overridden" > by items > # higher on the list. In the environment, just set the variable: > {code} > However actually bin/drill-config.sh sources drill-env.sh firstly, and then > distrib-env.sh. > {code:java} > drillEnv="$DRILL_CONF_DIR/drill-env.sh" > if [ -r "$drillEnv" ]; then > . "$drillEnv" > fi > ... > distribEnv="$DRILL_CONF_DIR/distrib-env.sh" > if [ -r "$distribEnv" ]; then > . "$distribEnv" > else > distribEnv="$DRILL_HOME/conf/distrib-env.sh" > if [ -r "$distribEnv" ]; then > . "$distribEnv" > fi > fi > {code} > We need to swap the source order of drill-env.sh and distrib-env.sh. -- This message was sent by Atlassian JIRA (v7.6.3#76005)