[
https://issues.apache.org/jira/browse/DRILL-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16811657#comment-16811657
]
ASF GitHub Bot commented on DRILL-7063:
---------------------------------------
amansinha100 commented on pull request #1723: DRILL-7063: Seperate metadata
cache file into summary, file metadata
URL: https://github.com/apache/drill/pull/1723#discussion_r272802585
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetFilterPushDown.java
##########
@@ -138,18 +138,22 @@ public void testIntPredicateWithEval() throws Exception {
testParquetRowGroupFilterEval(footer, "intCol = 50 or intCol = 160",
RowsMatch.SOME);
//"nonExistCol" does not exist in the table. "AND" with a filter on exist
column
+
testParquetRowGroupFilterEval(footer, "intCol > 100 and nonExistCol =
100", RowsMatch.NONE);
testParquetRowGroupFilterEval(footer, "intCol > 50 and nonExistCol = 100",
RowsMatch.NONE); // since nonExistCol = 100 -> Unknown -> could drop.
testParquetRowGroupFilterEval(footer, "nonExistCol = 100 and intCol > 50",
RowsMatch.NONE); // since nonExistCol = 100 -> Unknown -> could drop.
testParquetRowGroupFilterEval(footer, "intCol > 100 and nonExistCol <
'abc'", RowsMatch.NONE);
testParquetRowGroupFilterEval(footer, "nonExistCol < 'abc' and intCol >
100", RowsMatch.NONE); // nonExistCol < 'abc' hit NumberException and is
ignored, but intCol >100 will
+
// say "drop".
- testParquetRowGroupFilterEval(footer, "intCol > 50 and nonExistCol <
'abc'", RowsMatch.SOME); // because nonExistCol < 'abc' hit NumberException and
+// testParquetRowGroupFilterEval(footer, "intCol > 50 and nonExistCol <
'abc'", RowsMatch.SOME); // because nonExistCol < 'abc' hit NumberException and
Review comment:
What about this test ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create separate summary file for schema, totalRowCount, totalNullCount
> (includes maintenance)
> ---------------------------------------------------------------------------------------------
>
> Key: DRILL-7063
> URL: https://issues.apache.org/jira/browse/DRILL-7063
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Metadata
> Reporter: Venkata Jyothsna Donapati
> Assignee: Venkata Jyothsna Donapati
> Priority: Major
> Fix For: 1.16.0
>
> Original Estimate: 252h
> Remaining Estimate: 252h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
