[
https://issues.apache.org/jira/browse/DRILL-7165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814876#comment-16814876
]
ASF GitHub Bot commented on DRILL-7165:
---------------------------------------
vdiravka commented on issue #1743: DRILL-7165: Redundant Checksum calculating
for ASC files
URL: https://github.com/apache/drill/pull/1743#issuecomment-481870840
@sohami Couold you please review?
Here is one not mandatory change: `drill-root` -> `apache-drill` project
`artifactId`.
It is more convenient to use it as a parameter `${project.artifactId}` or
`${project.parent.artifactId}` instead of hardcoding `apache-drill` everywhere.
The question is it safe to change Drill project `artifactId`? Looks like
[`drill-root`](https://mvnrepository.com/artifact/org.apache.drill/drill-root)
isn't used by external tools.
Not sure there are other risks to rename it. If they are, please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Redundant Checksum calculating for ASC files
> --------------------------------------------
>
> Key: DRILL-7165
> URL: https://issues.apache.org/jira/browse/DRILL-7165
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.15.0
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Minor
> Fix For: 1.16.0
>
>
> Currently {{checksum-maven-plugin}} creates sha-512 checksum files for tar an
> zip archives and for ASC (signature) files. The last is redundant. For
> example:
> apache-drill-1.15.0-src.tar.gz.asc.sha512
> apache-drill-1.15.0-src.zip.asc.sha512
> apache-drill-1.15.0.tar.gz.asc.sha512
> The proper list of files:
> [http://home.apache.org/~vitalii/drill/releases/1.15.0/rc2/]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
