[ https://issues.apache.org/jira/browse/DRILL-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822052#comment-16822052 ]
Sorabh Hamirwasia edited comment on DRILL-7186 at 4/19/19 5:02 PM: ------------------------------------------------------------------- @vdiravka / [~arina] With DRILL-6562 I am seeing additional changes which is not supporting older requests URL. For example: 1) Earlier export of plugin config was done for json format by default using URL: */storage/\{name}/export* and now the new URL is */storage/\{name}/export/\{format}*. This means the older one is not supported anymore. Is it intended or should we treat the format as JSON by default if not provided ? 2) The POST URL to create and update plugin is changed from */storage/\{name}* to */storage/create_update* 3) Once a storage plugin is deleted it is not redirected to */storage* anymore, which it was in 1.15. Because of this line change: [https://github.com/apache/drill/commit/5fff1d8bff899e1af551c16f26a58b6b1d033ffb#diff-274673e64e6f54be595a8703753123b0R115] was (Author: shamirwasia): @vdiravka / [~arina] With DRILL-6562 I am seeing additional changes which is not supporting older requests URL. For example: 1) Earlier export of plugin config was done for json format by default using URL: */storage/\{name}/export* and now the new URL is */storage/\{name}/export/\{format}*. This means the older one is not supported anymore. Is it intended or should we treat the format as JSON by default if not provided ? 2) The POST URL to create and update plugin is changed from */storage/\{name}* to */storage/create_update* > Missing storage.json REST endpoint. > ----------------------------------- > > Key: DRILL-7186 > URL: https://issues.apache.org/jira/browse/DRILL-7186 > Project: Apache Drill > Issue Type: Bug > Affects Versions: 1.16.0 > Reporter: Anton Gozhiy > Assignee: Arina Ielchiieva > Priority: Blocker > Labels: ready-to-commit > Fix For: 1.16.0 > > > *Steps:* > 1. Open page: http://<server>:8047/storage.json > *Expected result:* > storage.json is opened: > {noformat} > [ { > "name" : "cp", > "config" : { > "type" : "file", > "connection" : "classpath:///", > "config" : null, > "workspaces" : { }, > "formats" : { > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "parquet" : { > "type" : "parquet" > }, > "avro" : { > "type" : "avro" > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "dfs", > "config" : { > "type" : "file", > "connection" : "file:///", > "config" : null, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "httpd" : { > "type" : "httpd", > "logFormat" : "%h %t \"%r\" %>s %b \"%{Referer}i\"" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "pcap" : { > "type" : "pcap" > }, > "pcapng" : { > "type" : "pcapng", > "extensions" : [ "pcapng" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > }, > "image" : { > "type" : "image", > "extensions" : [ "jpg", "jpeg", "jpe", "tif", "tiff", "dng", "psd", > "png", "bmp", "gif", "ico", "pcx", "wav", "wave", "avi", "webp", "mov", > "mp4", "m4a", "m4p", "m4b", "m4r", "m4v", "3gp", "3g2", "eps", "epsf", > "epsi", "ai", "arw", "crw", "cr2", "nef", "orf", "raf", "rw2", "rwl", "srw", > "x3f" ] > } > }, > "enabled" : true > } > }, { > "name" : "hbase", > "config" : { > "type" : "hbase", > "config" : { > "hbase.zookeeper.quorum" : "localhost", > "hbase.zookeeper.property.clientPort" : "2181" > }, > "size.calculator.enabled" : false, > "enabled" : false > } > }, { > "name" : "hive", > "config" : { > "type" : "hive", > "configProps" : { > "hive.metastore.uris" : "", > "javax.jdo.option.ConnectionURL" : > "jdbc:derby:;databaseName=../sample-data/drill_hive_db;create=true", > "hive.metastore.warehouse.dir" : "/tmp/drill_hive_wh", > "fs.default.name" : "file:///", > "hive.metastore.sasl.enabled" : "false", > "hive.metastore.schema.verification" : "false", > "datanucleus.schema.autoCreateAll" : "true" > }, > "enabled" : false > } > }, { > "name" : "kafka", > "config" : { > "type" : "kafka", > "kafkaConsumerProps" : { > "bootstrap.servers" : "localhost:9092", > "group.id" : "drill-consumer" > }, > "enabled" : false > } > }, { > "name" : "kudu", > "config" : { > "type" : "kudu", > "masterAddresses" : "1.2.3.4", > "enabled" : false > } > }, { > "name" : "mongo", > "config" : { > "type" : "mongo", > "connection" : "mongodb://localhost:27017/", > "enabled" : false > } > }, { > "name" : "opentsdb", > "config" : { > "type" : "openTSDB", > "connection" : "http://localhost:10000", > "enabled" : false > } > }, { > "name" : "s3", > "config" : { > "type" : "file", > "connection" : "s3a://my.bucket.location.com", > "config" : { > "fs.s3a.access.key" : "ID", > "fs.s3a.secret.key" : "SECRET" > }, > "workspaces" : { > "tmp" : { > "location" : "/tmp", > "writable" : true, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > }, > "root" : { > "location" : "/", > "writable" : false, > "defaultInputFormat" : null, > "allowAccessOutsideWorkspace" : false > } > }, > "formats" : { > "psv" : { > "type" : "text", > "extensions" : [ "tbl" ], > "delimiter" : "|" > }, > "csv" : { > "type" : "text", > "extensions" : [ "csv" ], > "delimiter" : "," > }, > "tsv" : { > "type" : "text", > "extensions" : [ "tsv" ], > "delimiter" : "\t" > }, > "parquet" : { > "type" : "parquet" > }, > "json" : { > "type" : "json", > "extensions" : [ "json" ] > }, > "avro" : { > "type" : "avro" > }, > "sequencefile" : { > "type" : "sequencefile", > "extensions" : [ "seq" ] > }, > "csvh" : { > "type" : "text", > "extensions" : [ "csvh" ], > "extractHeader" : true, > "delimiter" : "," > } > }, > "enabled" : false > } > } ] > {noformat} > *Actual result:* > {noformat} > { > "errorMessage" : "HTTP 404 Not Found" > } > {noformat} > *Note:* Works fine for individual plugin pages, like: /storage/dfs.json > This is regression after DRILL-6562. -- This message was sent by Atlassian JIRA (v7.6.3#76005)