[
https://issues.apache.org/jira/browse/DRILL-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822671#comment-16822671
]
ASF GitHub Bot commented on DRILL-7190:
---------------------------------------
arina-ielchiieva commented on pull request #1761: DRILL-7190: Missing backward
compatibility for REST API with DRILL-6562
URL: https://github.com/apache/drill/pull/1761#discussion_r277165204
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java
##########
@@ -221,6 +229,25 @@ private boolean isSupported(String format) {
.collect(Collectors.toList());
}
+ @POST
+ @Path("/storage/{name}")
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Deprecated // use {@link #createOrUpdatePluginJSON} instead
+ public JsonResult createOrUpdatePlugin(PluginConfigWrapper plugin) {
+ return createOrUpdatePluginJSON(plugin);
+ }
+
+ @GET
+ @Path("/storage/{name}/delete")
+ @Produces(MediaType.APPLICATION_JSON)
+ @Deprecated // use the method with DELETE request {@link
#deletePlugin(String)} instead
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Missing backward compatibility for REST API with DRILL-6562
> -----------------------------------------------------------
>
> Key: DRILL-7190
> URL: https://issues.apache.org/jira/browse/DRILL-7190
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.16.0
> Reporter: Sorabh Hamirwasia
> Assignee: Vitalii Diravka
> Priority: Blocker
> Fix For: 1.16.0
>
>
> With DRILL-6562 I am seeing additional changes which is not supporting older
> requests URL. For example:
> 1) Earlier export of plugin config was done for json format by default using
> URL: */storage/\{name}/export* and now the new URL is
> */storage/\{name}/export/\{format}*. This means the older one is not
> supported anymore. Is it intended or should we treat the format as JSON by
> default if not provided ?
> 2) The POST URL to create and update plugin is changed from
> */storage/\{name}* to */storage/create_update*
> 3) Once a storage plugin is deleted it is not redirected to */storage*
> anymore, which it was in 1.15. Because of this line change:
> [https://github.com/apache/drill/commit/5fff1d8bff899e1af551c16f26a58b6b1d033ffb#diff-274673e64e6f54be595a8703753123b0R115]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
