[
https://issues.apache.org/jira/browse/DRILL-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822936#comment-16822936
]
ASF GitHub Bot commented on DRILL-7098:
---------------------------------------
vvysotskyi commented on pull request #1754: DRILL-7098: File Metadata Metastore
Plugin
URL: https://github.com/apache/drill/pull/1754#discussion_r277232563
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScanWithMetadata.java
##########
@@ -151,13 +152,13 @@ public long getColumnValueCount(SchemaPath column) {
long colNulls;
if (columnStats != null) {
Long nulls = (Long)
columnStats.getStatistic(ColumnStatisticsKind.NULLS_COUNT);
- colNulls = nulls != null ? nulls : GroupScan.NO_COLUMN_STATS;
+ colNulls = nulls != null ? nulls : Statistic.NO_COLUMN_STATS;
} else {
return 0;
}
- return GroupScan.NO_COLUMN_STATS == tableRowCount
- || GroupScan.NO_COLUMN_STATS == colNulls
- ? GroupScan.NO_COLUMN_STATS : tableRowCount - colNulls;
+ return Statistic.NO_COLUMN_STATS == tableRowCount
+ || Statistic.NO_COLUMN_STATS == colNulls
+ ? Statistic.NO_COLUMN_STATS : tableRowCount - colNulls;
Review comment:
```suggestion
? Statistic.NO_COLUMN_STATS : tableRowCount - colNulls;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> File Metadata Metastore Plugin
> ------------------------------
>
> Key: DRILL-7098
> URL: https://issues.apache.org/jira/browse/DRILL-7098
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Server, Metadata
> Reporter: Vitalii Diravka
> Assignee: Vitalii Diravka
> Priority: Major
> Labels: Metastore
> Fix For: 2.0.0
>
>
> DRILL-6852 introduces Drill Metastore API.
> The second step is to create internal Drill Metastore mechanism (and File
> Metastore Plugin), which will involve Metastore API and can be extended for
> using by other Storage Plugins.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
