[
https://issues.apache.org/jira/browse/DRILL-7222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832770#comment-16832770
]
ASF GitHub Bot commented on DRILL-7222:
---------------------------------------
kkhatua commented on pull request #1779: DRILL-7222: Visualize estimated and
actual row counts for a query
URL: https://github.com/apache/drill/pull/1779#discussion_r280902167
##########
File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
##########
@@ -587,6 +622,49 @@
if (e.target.form)
<#if
model.isOnlyImpersonationEnabled()>doSubmitQueryWithUserName()<#else>doSubmitQueryWithAutoLimit()</#if>;
});
+
+ // Convert scientific to Decimal [Ref:
https://gist.github.com/jiggzson/b5f489af9ad931e3d186]
+ function scientificToDecimal(num) {
Review comment:
Ideally, yes.
But the way we construct the `Operators Overview` table is by only injecting
values (which then get converted to human readable formats based on data
types). That makes it difficult for me to inject these `<div>` elements during
construction.
Also, with Javascript, I reduce the processing and construction overhead on
the WebServer and have the client browsers do this formatting.
In theory, the entire profile can be constructed by Javascript from the JSON
profile, but basic summaries are easier to implement (and faster to calculate)
in Java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Visualize estimated and actual row counts for a query
> -----------------------------------------------------
>
> Key: DRILL-7222
> URL: https://issues.apache.org/jira/browse/DRILL-7222
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.16.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Major
> Labels: doc-impacting, user-experience
> Fix For: 1.17.0
>
>
> With statistics in place, it would be useful to have the *estimated* rowcount
> along side the *actual* rowcount query profile's operator overview.
> We can extract this from the Physical Plan section of the profile.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
