[
https://issues.apache.org/jira/browse/DRILL-7191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838777#comment-16838777
]
ASF GitHub Bot commented on DRILL-7191:
---------------------------------------
HanumathRao commented on pull request #1762: [DRILL-7191 / DRILL-7026]: RM
state blob persistence in Zookeeper and Integration of Distributed queue
configuration with Planner
URL: https://github.com/apache/drill/pull/1762#discussion_r283471493
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZookeeperClient.java
##########
@@ -227,13 +230,33 @@ public void create(final String path) {
final String target = PathUtils.join(root, path);
try {
- curator.create().withMode(mode).forPath(target);
+
curator.create().creatingParentsIfNeeded().withMode(mode).forPath(target);
getCache().rebuildNode(target);
} catch (final Exception e) {
throw new DrillRuntimeException("unable to put ", e);
}
}
+ public void createAsTransaction(List<String> paths) {
+ Preconditions.checkNotNull(paths, "no paths provided to create");
Review comment:
Is it also better to check for empty list of paths? Also it might be good to
add a comment for this function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> RM blobs persistence in Zookeeper for Distributed RM
> ----------------------------------------------------
>
> Key: DRILL-7191
> URL: https://issues.apache.org/jira/browse/DRILL-7191
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Server, Query Planning & Optimization
> Affects Versions: 1.17.0
> Reporter: Hanumath Rao Maduri
> Assignee: Sorabh Hamirwasia
> Priority: Major
> Fix For: 1.17.0
>
>
> Changes to support storing UUID for each Drillbit Service Instance locally to
> be used by planner and execution layer. This UUID is used to uniquely
> identify a Drillbit and register Drillbit information in the RM StateBlobs.
> Introduced a PersistentStore named ZookeeperTransactionalPersistenceStore
> with Transactional capabilities using Zookeeper Transactional API’s. This is
> used for updating RM State blobs as all the updates need to happen in
> transactional manner. Added RMStateBlobs definition and support for serde to
> Zookeeper.
> Implementation for DistributedRM and its corresponding QueryRM apis and state
> management.
> Updated the state management of Query in Foreman so that same Foreman object
> can be submitted multiple times. Also introduced concept of 2 maps keeping
> track of waiting and running queries. These were done to support for async
> admit protocol which will be needed with Distributed RM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
