[
https://issues.apache.org/jira/browse/DRILL-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838999#comment-16838999
]
ASF GitHub Bot commented on DRILL-7242:
---------------------------------------
amansinha100 commented on pull request #1785: DRILL-7242: Handle additional
boundary cases and compute better estim…
URL: https://github.com/apache/drill/pull/1785#discussion_r283596694
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/common/TestNumericEquiDepthHistogram.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner.common;
+
+import org.apache.drill.categories.PlannerTest;
+
+import org.apache.drill.shaded.guava.com.google.common.collect.BoundType;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.Assert;
+import org.apache.drill.shaded.guava.com.google.common.collect.Range;
+
+
+@Category(PlannerTest.class)
+public class TestNumericEquiDepthHistogram {
+
+ @Test
+ public void testHistogramWithUniqueEndpoints() throws Exception {
+ int numBuckets = 10;
+ int numRowsPerBucket = 250;
+
+ // init array with numBuckets + 1 values
+ Double[] buckets = {1.0, 10.0, 20.0, 30.0, 40.0, 50.0, 60.0, 70.0, 80.0,
90.0, 100.0};
+
+ NumericEquiDepthHistogram histogram = new
NumericEquiDepthHistogram(numBuckets);
+
+ for (int i = 0; i < buckets.length; i++) {
+ histogram.setBucketValue(i, buckets[i]);
+ }
+ histogram.setNumRowsPerBucket(numRowsPerBucket);
+
+ // Range: <= 1.0
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Query with range predicate hits IOBE when accessing histogram buckets
> ---------------------------------------------------------------------
>
> Key: DRILL-7242
> URL: https://issues.apache.org/jira/browse/DRILL-7242
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization
> Affects Versions: 1.16.0
> Reporter: Aman Sinha
> Assignee: Aman Sinha
> Priority: Major
> Fix For: 1.17.0
>
>
> Following query hits an IOBE during histogram access: (make sure to run
> ANALYZE command before running this query):
> {noformat}
> select 1 from dfs.tmp.employee where store_id > 24;
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 11
> at
> org.apache.drill.exec.planner.common.NumericEquiDepthHistogram.getSelectedRows(NumericEquiDepthHistogram.java:215)
> ~[drill-java-exec-1.16.0.0-mapr.jar:1.16.0.0-mapr]
> at
> org.apache.drill.exec.planner.common.NumericEquiDepthHistogram.estimatedSelectivity(NumericEquiDepthHistogram.java:130)
> ~[drill-java-exec-1.16.0.0-mapr.jar:1.16.0.0-mapr]
> at
> org.apache.drill.exec.planner.cost.DrillRelMdSelectivity.computeRangeSelectivity(DrillRelMd
> {noformat}
> Here, 24.0 is the end point of the last histogram bucket and the boundary
> condition is not being correctly handled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
