[
https://issues.apache.org/jira/browse/DRILL-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854860#comment-16854860
]
ASF GitHub Bot commented on DRILL-7278:
---------------------------------------
arina-ielchiieva commented on pull request #1797: DRILL-7278: Refactor result
set loader projection mechanism
URL: https://github.com/apache/drill/pull/1797#discussion_r289946314
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/project/RequestedTupleImpl.java
##########
@@ -74,6 +75,7 @@
public class RequestedTupleImpl implements RequestedTuple {
private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(RequestedTupleImpl.class);
+ private static final Collection<SchemaPath> PROJECT_ALL =
ImmutableList.of(SchemaPath.STAR_COLUMN);
Review comment:
Consider using build-in Java methods instead of guava when possible:
`Collections.sigletonList`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor result set loader projection mechanism
> -----------------------------------------------
>
> Key: DRILL-7278
> URL: https://issues.apache.org/jira/browse/DRILL-7278
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.17.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
