[
https://issues.apache.org/jira/browse/DRILL-7292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862945#comment-16862945
]
ASF GitHub Bot commented on DRILL-7292:
---------------------------------------
arina-ielchiieva commented on pull request #1806: DRILL-7292: Remove V1 and V2
text readers
URL: https://github.com/apache/drill/pull/1806#discussion_r293320197
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -713,11 +713,26 @@ private ExecConstants() {
public static final OptionValidator ENABLE_VERBOSE_ERRORS = new
BooleanValidator(ENABLE_VERBOSE_ERRORS_KEY,
new OptionDescription("Toggles verbose output of executable error
messages"));
+ /**
+ * Key used in earlier versions to use the original ("V1") text reader.
Since at least Drill 1.8
+ * users have used the ("compliant") ("V2") version. Deprecated in Drill
1.17; the "V3" reader
+ * with schema support is always used. Retained for backward compatibility,
but does
+ * nothing.
+ */
+ @Deprecated
public static final String ENABLE_NEW_TEXT_READER_KEY =
"exec.storage.enable_new_text_reader";
+ @Deprecated
public static final OptionValidator ENABLE_NEW_TEXT_READER = new
BooleanValidator(ENABLE_NEW_TEXT_READER_KEY,
new OptionDescription("Enables the text reader that complies with the
RFC 4180 standard for text/csv files."));
Review comment:
Please update option description in `new OptionDescription("Enables the text
reader that complies with the RFC 4180 standard for text/csv files."));`, this
is what users see on Web UI and options table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove V1, V2 text readers
> --------------------------
>
> Key: DRILL-7292
> URL: https://issues.apache.org/jira/browse/DRILL-7292
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.17.0
>
>
> Now that the "V3" text reader (based on the "extended vector framework) is
> fully functional, we wish to remove the prior (V2) text reader.
> Drill also contains the original, "V1" text reader that has not been used or
> supported for several years. We will remove this reader also to leave the
> code simpler and cleaner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
