[
https://issues.apache.org/jira/browse/DRILL-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876829#comment-16876829
]
ASF GitHub Bot commented on DRILL-7200:
---------------------------------------
arina-ielchiieva commented on pull request #1818: DRILL-7200: Update Calcite to
1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299400445
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/ViewHandler.java
##########
@@ -66,7 +66,7 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws
ValidationException, RelConv
// Disallow temporary tables usage in view definition
config.getConverter().disallowTemporaryTables();
// Store the viewSql as view def SqlNode is modified as part of the
resolving the new table definition below.
- final String viewSql = createView.getQuery().toString();
+ final String viewSql = createView.getQuery().toSqlString(null,
true).getSql();
Review comment:
Please add unit test for this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update Calcite to 1.19.0 / 1.20.0
> ---------------------------------
>
> Key: DRILL-7200
> URL: https://issues.apache.org/jira/browse/DRILL-7200
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.16.0
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.17.0
>
>
> Calcite has released the 1.19.0 version. Upgrade Calcite dependency in Drill
> to the newest version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
