[
https://issues.apache.org/jira/browse/DRILL-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878841#comment-16878841
]
ASF GitHub Bot commented on DRILL-7307:
---------------------------------------
vvysotskyi commented on pull request #1820: DRILL-7307: casthigh for decimal
type can lead to the issues with VarDecimalHolder
URL: https://github.com/apache/drill/pull/1820#discussion_r300472041
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/EvaluationVisitor.java
##########
@@ -1126,327 +1131,159 @@ public HoldingContainer
visitFunctionCall(FunctionCall e, ClassGenerator<?> gene
+ "It should have been converted to FunctionHolderExpression in
materialization");
}
- @Override
- public HoldingContainer
visitFunctionHolderExpression(FunctionHolderExpression e, ClassGenerator<?>
generator)
+ private <T> HoldingContainer visitExpression(T e, ClassGenerator<?>
generator, GetHolderCall getHolder)
throws RuntimeException {
if (constantBoundaries.contains(e)) {
generator.getMappingSet().enterConstant();
- HoldingContainer c = super.visitFunctionHolderExpression(e, generator);
- // generator.getMappingSet().exitConstant();
- // return c;
- return renderConstantExpression(generator, c);
+ HoldingContainer c = getHolder.call();
Review comment:
Please rename it to something more meaningful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> casthigh for decimal type can lead to the issues with VarDecimalHolder
> ----------------------------------------------------------------------
>
> Key: DRILL-7307
> URL: https://issues.apache.org/jira/browse/DRILL-7307
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Dmytriy Grinchenko
> Assignee: Dmytriy Grinchenko
> Priority: Critical
> Fix For: 1.17.0
>
>
> The decimal cast may lead to issues with VarDercimal transformation and
> issues at uml functions which using casthigh under the hood
> Example:
> {code}
> apache drill> select casthigh(cast(1025.0 as decimal(28,8)));
> Error: SYSTEM ERROR: CompileException: Line 25, Column 60: "isSet" is neither
> a method, a field, nor a member class of
> "org.apache.drill.exec.expr.holders.VarDecimalHolder"
> Fragment 0:0
> Please, refer to logs for more information.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
