[
https://issues.apache.org/jira/browse/DRILL-7315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879269#comment-16879269
]
ASF GitHub Bot commented on DRILL-7315:
---------------------------------------
ihuzenko commented on pull request #1821: DRILL-7315: Revise precision and
scale order in the method arguments
URL: https://github.com/apache/drill/pull/1821#discussion_r300682494
##########
File path: common/src/main/java/org/apache/drill/common/types/Types.java
##########
@@ -549,7 +549,7 @@ public static MajorType withPrecision(final MinorType
type, final DataMode mode,
return
MajorType.newBuilder().setMinorType(type).setMode(mode).setPrecision(precision).build();
}
- public static MajorType withScaleAndPrecision(final MinorType type, final
DataMode mode, final int scale, final int precision) {
+ public static MajorType withScaleAndPrecision(MinorType type, DataMode mode,
int precision, int scale) {
Review comment:
```suggestion
public static MajorType withPrecisionAndScale(MinorType type, DataMode
mode, int precision, int scale) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Revise precision and scale order in the method arguments
> --------------------------------------------------------
>
> Key: DRILL-7315
> URL: https://issues.apache.org/jira/browse/DRILL-7315
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.16.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.17.0
>
>
> The current code has different variations of scale and precision orderings in
> the method arguments. The goal for this Jira is to make it more consistent.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
