[
https://issues.apache.org/jira/browse/DRILL-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879859#comment-16879859
]
ASF GitHub Bot commented on DRILL-7317:
---------------------------------------
vvysotskyi commented on pull request #1822: DRILL-7317: Close ClassLoaders used
for udf jars uploading when closing FunctionImplementationRegistry
URL: https://github.com/apache/drill/pull/1822#discussion_r300868113
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/registry/FunctionRegistryHolder.java
##########
@@ -376,28 +377,78 @@ private void removeAllByJar(String jarName) {
return;
}
+ boolean isClosed = false;
for (Map.Entry<String, Queue<String>> functionEntry : jar.entrySet()) {
final String function = functionEntry.getKey();
Map<String, DrillFuncHolder> functionHolders = functions.get(function);
Queue<String> functionSignatures = functionEntry.getValue();
- for (Map.Entry<String, DrillFuncHolder> entry :
functionHolders.entrySet()) {
- if (functionSignatures.contains(entry.getKey())) {
- ClassLoader classLoader = entry.getValue().getClassLoader();
- if (classLoader instanceof AutoCloseable) {
- try {
- ((AutoCloseable) classLoader).close();
- } catch (Exception e) {
- logger.warn("Problem during closing class loader", e);
- }
- }
- break;
- }
- }
+ // closes class loader only one time
+ isClosed = !isClosed && closeClassLoader(function, functionSignatures);
Review comment:
That's correct that there is only one classloader per jar, but except
closing it, we should also remove function signatures from `functions` map, so
we need to iterate further.
With the current code, `closeClassLoader` method is called only once per jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Close ClassLoaders used for udf jars uploading when closing
> FunctionImplementationRegistry
> ------------------------------------------------------------------------------------------
>
> Key: DRILL-7317
> URL: https://issues.apache.org/jira/browse/DRILL-7317
> Project: Apache Drill
> Issue Type: Task
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.17.0
>
>
> For the case when {{FunctionImplementationRegistry}} is closed, class loaders
> which were used for uploading jars are still open and don't close file
> descriptors for these jars.
> The proposal is to unregister jars to close its {{ClassLoader}} whenÂ
> {{FunctionImplementationRegistry}} is closed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
