[
https://issues.apache.org/jira/browse/DRILL-7096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16895296#comment-16895296
]
ASF GitHub Bot commented on DRILL-7096:
---------------------------------------
KazydubB commented on pull request #1829: DRILL-7096: Develop vector for
canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r308256681
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/TrueMapVector.java
##########
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.vector.complex;
+
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+
+import org.apache.drill.common.exceptions.DrillRuntimeException;
+import org.apache.drill.common.types.TypeProtos.MajorType;
+import org.apache.drill.common.types.TypeProtos.MinorType;
+import org.apache.drill.common.types.Types;
+import org.apache.drill.exec.expr.holders.TrueMapHolder;
+import org.apache.drill.exec.memory.BufferAllocator;
+import org.apache.drill.exec.record.MaterializedField;
+import org.apache.drill.exec.record.TransferPair;
+import org.apache.drill.exec.util.CallBack;
+import org.apache.drill.exec.util.JsonStringHashMap;
+import org.apache.drill.exec.vector.SchemaChangeCallBack;
+import org.apache.drill.exec.vector.ValueVector;
+import org.apache.drill.exec.vector.complex.impl.SingleTrueMapReaderImpl;
+
+public final class TrueMapVector extends RepeatedMapVector {
+
+ public final static MajorType TYPE = Types.optional(MinorType.TRUEMAP);
+
+ public static final String FIELD_KEY_NAME = "key";
+ public static final String FIELD_VALUE_NAME = "value";
+ public static final List<String> fieldNames =
Collections.unmodifiableList(Arrays.asList(FIELD_KEY_NAME, FIELD_VALUE_NAME));
+
+ private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(TrueMapVector.class);
+
+ private final Accessor accessor = new Accessor();
+ private final Mutator mutator = new Mutator();
+ private final SingleTrueMapReaderImpl reader;
+
+ private MajorType keyType;
+ private MajorType valueType;
+
+ public TrueMapVector(MaterializedField field, BufferAllocator allocator,
CallBack callBack) {
+ super(field.clone(), allocator, callBack);
+ reader = new SingleTrueMapReaderImpl(TrueMapVector.this);
+ }
+
+ public TrueMapVector(MaterializedField field, BufferAllocator allocator,
CallBack callBack, MajorType keyType, MajorType valueType) {
+ this(field.clone(), allocator, callBack);
Review comment:
Good catch, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Develop vector for canonical Map<K,V>
> -------------------------------------
>
> Key: DRILL-7096
> URL: https://issues.apache.org/jira/browse/DRILL-7096
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Igor Guzenko
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.17.0
>
>
> Canonical Map<K,V> datatype can be represented using combination of three
> value vectors:
> keysVector - vector for storing keys of each map
> valuesVector - vector for storing values of each map
> offsetsVector - vector for storing of start indexes of next each map
> So it's not very hard to create such Map vector, but there is a major issue
> with such map representation. It's hard to search maps values by key in such
> vector, need to investigate some advanced techniques to make such search
> efficient. Or find other more suitable options to represent map datatype in
> world of vectors.
> After question about maps, Apache Arrow developers responded that for Java
> they don't have real Map vector, for now they just have logical Map type
> definition where they define Map like: List< Struct<key:key_type,
> value:value_type> >. So implementation of value vector would be useful for
> Arrow too.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
