[
https://issues.apache.org/jira/browse/DRILL-7351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951325#comment-16951325
]
ASF GitHub Bot commented on DRILL-7351:
---------------------------------------
arina-ielchiieva commented on pull request #1864: DRILL-7351: Added tokens to
Web forms to prevent CSRF attacks
URL: https://github.com/apache/drill/pull/1864#discussion_r334647057
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/CsrfTokenInjectFilter.java
##########
@@ -43,11 +43,14 @@ public void init(FilterConfig filterConfig) throws
ServletException {
public void doFilter(ServletRequest request, ServletResponse response,
FilterChain chain) throws IOException, ServletException {
HttpServletRequest httpRequest = (HttpServletRequest) request;
if (HttpMethod.GET.equalsIgnoreCase(httpRequest.getMethod())) {
+ // We don't create a session with this call as we need to check if there
is a session already (i.e. if a user is logged in).
HttpSession session = httpRequest.getSession(false);
if (session != null) {
String csrfToken = (String)
session.getAttribute(WebServerConstants.CSRF_TOKEN);
if (csrfToken == null) {
- csrfToken = RandomStringUtils.random(20, 0, 0, true, true, null, new
SecureRandom());
+ byte[] buffer = new byte[32];
Review comment:
As I have asked before please explain choice of creating the token. Even
better extract it into separate method and add good java doc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> WebUI is Vulnerable to CSRF
> ---------------------------
>
> Key: DRILL-7351
> URL: https://issues.apache.org/jira/browse/DRILL-7351
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.16.0
> Reporter: Don Perial
> Assignee: Anton Gozhiy
> Priority: Major
> Fix For: 1.17.0
>
> Attachments: Screen Shot 2019-08-19 at 10.11.50 AM.png,
> drill-csrf.html
>
>
> There is no way to protect the WebUI from CSRF and the fact that the value
> for the access-control-allow-origin header is '*' appears to confound this
> issue as well.
> The attached file demonstrates the vulnerability.
> Steps to replicate:
> # Login to an instance of the Drill WebUI.
> # Edit the attached [^drill-csrf.html]. Replace DRILL_HOST with the hostname
> of the Drill WebUI from step #1.
> # Load the file from #2 in the same browser as #1 either new tab or same
> window will do.
> # Return to the Drill WebUI and click on 'Profiles'.
> Observed results:
> The query 'SELECT 100' appears in the list of executed queries (see:
> [^Screen Shot 2019-08-19 at 10.11.50 AM.png] ).
> Expected results:
> It should be possible to whitelist or completely restrict code from other
> domain names to submit queries to the WebUI.
> Risks:
> Potential for code execution by unauthorized parties.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
