[ https://issues.apache.org/jira/browse/DRILL-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vova Vysotskyi updated DRILL-7401: ---------------------------------- Labels: ready-to-commit (was: ) > Sqlline 1.9 upgrade > ------------------- > > Key: DRILL-7401 > URL: https://issues.apache.org/jira/browse/DRILL-7401 > Project: Apache Drill > Issue Type: Task > Reporter: Arina Ielchiieva > Assignee: Arina Ielchiieva > Priority: Major > Labels: ready-to-commit > Fix For: 1.17.0 > > > Upgrade to SqlLine 1.9 once it is released > (https://github.com/julianhyde/sqlline/issues/350). > *TODO:* > 1. Add SqlLine properties: > {{connectInteractionMode: useNPTogetherOrEmpty}} - supports connection > mehanism used in SqlLine 1.17 and earlier: > a. if user and password are not indicated, connects without them (user and > password are set t empty string): {{./drill-embedded}} > b. if user is indicated, asks for password in interactive mode: > {{./drill-embedded -n "user1"}} > c. if user is indicated as empty string, behaives like in point a (user and > password are set t empty string): {{./drill-embedded -n ""}} > d. if user and password are indicated, connects using provided input > {{./drill-embedded -n "user1" -p "123"}} > {{showLineNumbers: true}} - adds line numbers when query is more than one > line: > {noformat} > apache drill> select > 2..semicolon> * > 3..semicolon> from > 4..semicolon> sys.version; > {noformat} > 2. Remove nohup support code from sqlline.sh since it is not needed any more > (nohup support wroks without flag): > {code} > To add nohup support for SQLline script > if [[ ( ! $(ps -o stat= -p $$) =~ "+" ) && ! ( -p /dev/stdin ) ]]; then > export SQLLINE_JAVA_OPTS="$SQLLINE_JAVA_OPTS > -Djline.terminal=jline.UnsupportedTerminal" > fi > {code} > 3. Add {{-Dorg.jline.terminal.dumb=true}} to avoid JLine terminal warning > when submitting query in sqlline.sh to execute via {{-e}} or {{-f}}: > {noformat} > Oct 11, 2019 2:14:45 PM org.jline.utils.Log logr > WARNING: Unable to create a system terminal, creating a dumb terminal (enable > debug logging for more information) > {noformat} > 4. Remove unneeded echo commands in sqlline.bat during start up: > {noformat} > drill-embedded.bat > DRILL_ARGS - " -u jdbc:drill:zk=local -n user1 -p ppp" > Calculating HADOOP_CLASSPATH ... > HBASE_HOME not detected... > Calculating Drill classpath... > Apache Drill 1.17.0-SNAPSHOT > "Data is the new oil. Ready to Drill some?" > apache drill> > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)