[
https://issues.apache.org/jira/browse/DRILL-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956657#comment-16956657
]
ASF GitHub Bot commented on DRILL-5674:
---------------------------------------
paul-rogers commented on pull request #1879: DRILL-5674: Support ZIP compression
URL: https://github.com/apache/drill/pull/1879#discussion_r337321291
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
##########
@@ -386,17 +387,16 @@ public static void checkBackPaths(String parent, String
combinedPath, String sub
Preconditions.checkArgument(!combinedPath.isEmpty(), "Empty path (" +
combinedPath + "( in file selection path.");
if (!combinedPath.startsWith(parent)) {
- StringBuilder msg = new StringBuilder();
- msg.append("Invalid path : ").append(subpath).append(" takes you outside
the workspace.");
- throw new IllegalArgumentException(msg.toString());
+ throw new IllegalArgumentException(
+ String.format("Invalid path [%s] takes you outside the workspace.",
subpath));
}
}
public List<FileStatus> getFileStatuses() {
return statuses;
}
- public boolean supportDirPrunig() {
+ public boolean supportDirPruning() {
Review comment:
Good catch. `suppportsDirPruning` (with an s)?
The `support` form is imperative, it tells this object to support dir
pruning. The `supports` form asks if this object does or does not support dir
pruning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Drill should support .zip compression
> -------------------------------------
>
> Key: DRILL-5674
> URL: https://issues.apache.org/jira/browse/DRILL-5674
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Text & CSV
> Affects Versions: 1.10.0
> Reporter: Paul Rogers
> Assignee: Arina Ielchiieva
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.17.0
>
>
> Zip is a very common compression format. Create a compressed CSV file with
> column headers: data.csv.zip.
> Define a storage plugin config for the file, call it "dfs.myws", set
> delimiter = ",", extract header = true, skip header = false.
> Run a simple query:
> SELECT * FROM dfs.myws.`data.csv.zip`
> The result is garbage as the CSV reader is trying to parse Zipped data as if
> it were text.
> DRILL-5506 asks how to do this; the responder said to add a library to the
> path. Better would be to simply support zip out-of-the-box as a default
> format.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
