[
https://issues.apache.org/jira/browse/DRILL-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956970#comment-16956970
]
ASF GitHub Bot commented on DRILL-5674:
---------------------------------------
arina-ielchiieva commented on pull request #1879: DRILL-5674: Support ZIP
compression
URL: https://github.com/apache/drill/pull/1879#discussion_r337453494
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java
##########
@@ -57,7 +61,9 @@
*/
public class FileSystemPlugin extends AbstractStoragePlugin {
- private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(FileSystemPlugin.class);
+ private static final Logger logger =
LoggerFactory.getLogger(FileSystemPlugin.class);
+
+ private static final List<String> BUILT_IN_CODECS =
Collections.singletonList(ZipCodec.class.getCanonicalName());
Review comment:
`org.apache.hadoop.io.compress` library supports gzip / bzip2 out of box.
Here we only need to add codecs that are missing in this library. I have
updated parameter name and added comment to avoid the confusion.
`TestCompressedFiles` contains tests for all supported formats.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Drill should support .zip compression
> -------------------------------------
>
> Key: DRILL-5674
> URL: https://issues.apache.org/jira/browse/DRILL-5674
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Text & CSV
> Affects Versions: 1.10.0
> Reporter: Paul Rogers
> Assignee: Arina Ielchiieva
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.17.0
>
>
> Zip is a very common compression format. Create a compressed CSV file with
> column headers: data.csv.zip.
> Define a storage plugin config for the file, call it "dfs.myws", set
> delimiter = ",", extract header = true, skip header = false.
> Run a simple query:
> SELECT * FROM dfs.myws.`data.csv.zip`
> The result is garbage as the CSV reader is trying to parse Zipped data as if
> it were text.
> DRILL-5506 asks how to do this; the responder said to add a library to the
> path. Better would be to simply support zip out-of-the-box as a default
> format.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
