[
https://issues.apache.org/jira/browse/DRILL-7417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16959130#comment-16959130
]
ASF GitHub Bot commented on DRILL-7417:
---------------------------------------
sohami commented on pull request #1880: DRILL-7417: Add user logged in/out
event in info level logs
URL: https://github.com/apache/drill/pull/1880#discussion_r338723489
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java
##########
@@ -120,6 +123,12 @@ public Viewable getLoginPageAfterValidationError() {
public void logout(@Context HttpServletRequest req, @Context
HttpServletResponse resp) throws Exception {
final HttpSession session = req.getSession();
if (session != null) {
+ final Object authCreds =
session.getAttribute(SessionAuthentication.__J_AUTHENTICATED);
+ if (authCreds != null) {
+ final SessionAuthentication sessionAuth = (SessionAuthentication)
authCreds;
+ logger.info("WebUser {} logged out from {}:{}",
sessionAuth.getUserIdentity().getUserPrincipal().getName(), req
Review comment:
I will prefer it without space since that's the usual convention for
`ip:port` string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add user logged in/out event in info level logs
> -----------------------------------------------
>
> Key: DRILL-7417
> URL: https://issues.apache.org/jira/browse/DRILL-7417
> Project: Apache Drill
> Issue Type: Improvement
> Components: Security
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
