[
https://issues.apache.org/jira/browse/DRILL-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16966321#comment-16966321
]
ASF GitHub Bot commented on DRILL-7436:
---------------------------------------
paul-rogers commented on pull request #1889: DRILL-7436: Fix record count,
vector structure issues in several operators
URL: https://github.com/apache/drill/pull/1889
Adds additional vector checks to the `BatchValidator`.
Enables checking for the following operators:
* `FilterRecordBatch`
* `PartitionLimitRecordBatch`
* `UnnestRecordBatch`
* `HashAggBatch`
* `RemovingRecordBatch`
Fixes vector count issues for each of these.
Fixes empty-batch (record count = 0) handling in several of the
above operators. Added a method to `VectorContainer` to correctly
create an empty batch. (An empty batch, counter-intuitively,
needs vectors allocated to hold the 0 value in the first
position of each offset vector.)
Disables verbose logging for MongoDB tests. Details are written to
the log rather than the console.
Disables two invalid Mongo tests. See DRILL-7428.
Adjusts the expression tree materializer to not add the LATE type
to Union vectors. (See DRILL-7435.)
Ensures that Union vectors contain valid vectors for each subtype.
The present fix is a work-around, see DRILL-7434 for a better
long-term fix.
Cleans up code formatting and other minor issues in each file touched
during the fixes in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix record count, vector structure issues in several operators
> --------------------------------------------------------------
>
> Key: DRILL-7436
> URL: https://issues.apache.org/jira/browse/DRILL-7436
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
>
> This is the next in a continuing series of fixes to the container record
> count, batch record count, and vector structure in several operators. This
> batch represents the smallest change needed to add checking for the Filter
> operator.
> In order to get Filter to pass checks, many of its upstream operators needed
> to be fixed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
