[
https://issues.apache.org/jira/browse/DRILL-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970404#comment-16970404
]
ASF GitHub Bot commented on DRILL-6540:
---------------------------------------
vvysotskyi commented on pull request #1895: DRILL-6540: Upgrade to HADOOP-3.x
libraries
URL: https://github.com/apache/drill/pull/1895#discussion_r344263499
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/LocalSyncableFileSystem.java
##########
@@ -65,7 +65,7 @@ public FSDataInputStream open(Path path, int i) throws
IOException {
@Override
public FSDataOutputStream create(Path path, FsPermission fsPermission,
boolean b, int i, short i2, long l, Progressable progressable) throws
IOException {
- return new FSDataOutputStream(new LocalSyncableOutputStream(path));
+ return new FSDataOutputStream(new LocalSyncableOutputStream(path), new
Statistics(path.toUri().getScheme()));
Review comment:
Wouldn't it be better to obtain the `Statistics` instance using its static
method `Statistics.getStatistics(String scheme, Class<? extends FileSystem>
cls)` to use cached instance instead of creating the new one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade to HADOOP-3.0 libraries
> --------------------------------
>
> Key: DRILL-6540
> URL: https://issues.apache.org/jira/browse/DRILL-6540
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.14.0
> Reporter: Vitalii Diravka
> Assignee: Anton Gozhiy
> Priority: Major
> Fix For: 1.18.0
>
>
> Currently Drill uses 2.7.4 version of hadoop libraries (hadoop-common,
> hadoop-hdfs, hadoop-annotations, hadoop-aws, hadoop-yarn-api, hadoop-client,
> hadoop-yarn-client).
> A year ago the [Hadoop 3.0|https://hadoop.apache.org/docs/r3.0.0/index.html]
> was released and recently it was updated to [Hadoop
> 3.2.0|https://hadoop.apache.org/docs/r3.2.0/].
> To use Drill under Hadoop3.0 distribution we need this upgrade. Also the
> newer version includes new features, which can be useful for Drill.
> This upgrade is also needed to leverage the newest version of Zookeeper
> libraries and Hive 3.1 version.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
