[
https://issues.apache.org/jira/browse/DRILL-7445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976560#comment-16976560
]
ASF GitHub Bot commented on DRILL-7445:
---------------------------------------
ihuzenko commented on pull request #1899: DRILL-7445: Create batch copier based
on result set framework
URL: https://github.com/apache/drill/pull/1899#discussion_r347383123
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/convert/AbstractWriteConverter.java
##########
@@ -143,4 +144,9 @@ public void setTime(LocalTime value) {
public void setTimestamp(Instant value) {
baseWriter.setTimestamp(value);
}
+
+ @Override
+ public void copy(ColumnReader from) {
+ throw new UnsupportedOperationException("Cannot copy values through a type
converter");
Review comment:
If type converters shouldn't support copy then maybe makes sense to mark the
method as final here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Create batch copier based on result set framework
> -------------------------------------------------
>
> Key: DRILL-7445
> URL: https://issues.apache.org/jira/browse/DRILL-7445
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.16.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.17.0
>
>
> The result set framework now provides both a reader and writer. Provide a
> copier that copies batches using this framework. Such a copier can:
> * Copy selected records
> * Copy all records, such as for an SV2 or SV4
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
