[
https://issues.apache.org/jira/browse/DRILL-7359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004016#comment-17004016
]
ASF GitHub Bot commented on DRILL-7359:
---------------------------------------
KazydubB commented on pull request #1870: DRILL-7359: Add support for DICT type
in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r361611436
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/impl/ColumnBuilder.java
##########
@@ -179,6 +189,19 @@ private ColumnState buildPrimitive(ContainerState parent,
ColumnReadProjection c
vectorState);
}
+ /**
+ * Check if this is a special case when vector, writer and column state
should be
+ * created for a primitive field though the field itself is not projected.
This is
+ * needed because {@code DICT}'s {@code keys} field is not projected but is
needed
+ * to be initialized to ensure the dict vector is constructed properly.
Review comment:
Dict works the same as arrays regarding projection: if the user refers to
any `DICT` entry, the whole `DICT` is projected and finding the needed entry is
to be handled by some other operator. This entry is not filtered in the Scan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for DICT type in RowSet Framework
> ---------------------------------------------
>
> Key: DRILL-7359
> URL: https://issues.apache.org/jira/browse/DRILL-7359
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Fix For: 1.18.0
>
>
> Add support for new DICT data type (see DRILL-7096) in RowSet Framework
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
