[ 
https://issues.apache.org/jira/browse/DRILL-7507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17007343#comment-17007343
 ] 

ASF GitHub Bot commented on DRILL-7507:
---------------------------------------

arina-ielchiieva commented on issue #1949: DRILL-7507: Convert fragment 
interrupts to exceptions
URL: https://github.com/apache/drill/pull/1949#issuecomment-570514096
 
 
   +1, @paul-rogers please squash the commits.
   P.S. There is no need to leave rebase commit, I think reviewer does not need 
to spend time reviewing rebase and then asking for commits to be squashed.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Convert fragment interrupts to exceptions
> -----------------------------------------
>
>                 Key: DRILL-7507
>                 URL: https://issues.apache.org/jira/browse/DRILL-7507
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.17.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Major
>              Labels: ready-to-commit
>             Fix For: 1.18.0
>
>
> Operations periodically check if they should continue by calling the 
> {{shouldContinue()}} method. If the method returns false, operators return a 
> {{STOP}} status in some form.
> This change modifies handling to throw an exception instead; cancelling a 
> fragment the same way that we handle errors.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to