[
https://issues.apache.org/jira/browse/DRILL-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038318#comment-17038318
]
ASF GitHub Bot commented on DRILL-7586:
---------------------------------------
vvysotskyi commented on pull request #1984: DRILL-7586: drill-hive-exec-shaded
contains commons-lang3 version 3.1
URL: https://github.com/apache/drill/pull/1984#discussion_r380155881
##########
File path: contrib/storage-hive/hive-exec-shade/pom.xml
##########
@@ -158,6 +158,8 @@
you can use
TestHiveStorage.readFromAlteredPartitionedTableWithEmptyGroupType() test case.
-->
<exclude>org/apache/parquet/**</exclude>
<exclude>shaded/parquet/org/**</exclude>
+ <exclude>org/apache/commons/lang/**</exclude>
Review comment:
I'm afraid it can break something since hive explicitly includes these
libraries into `hive-exec` jar:
https://github.com/apache/hive/blob/master/ql/pom.xml#L958.
As an alternative solution, I would recommend relocating them (as it is done
above for other libraries).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> drill-hive-exec-shaded contains commons-lang3 version 3.1
> ---------------------------------------------------------
>
> Key: DRILL-7586
> URL: https://issues.apache.org/jira/browse/DRILL-7586
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.16.0, 1.17.0
> Reporter: Oleg Zinoviev
> Assignee: Oleg Zinoviev
> Priority: Major
>
> org.apache.hive:hive-exec contains shaded commons-lang3 library version 3.1.
> During the Drill build, these classes are added to the Vasya library. This
> causes an incorrect version of StringUtils to be loaded in runtime (since the
> jars directory is found in classpath earlier than jars/3rdparty)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
