[
https://issues.apache.org/jira/browse/DRILL-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047634#comment-17047634
]
ASF GitHub Bot commented on DRILL-7203:
---------------------------------------
arina-ielchiieva commented on pull request #1994: DRILL-7203: Accept
impersonation userName as form field & fix back button for query page
URL: https://github.com/apache/drill/pull/1994#discussion_r385700321
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/QueryWrapper.java
##########
@@ -48,13 +53,21 @@
private final String queryType;
private final int autoLimitRowCount;
+ @Nullable
+ private final String userName;
+
private static MemoryMXBean memMXBean = ManagementFactory.getMemoryMXBean();
@JsonCreator
- public QueryWrapper(@JsonProperty("query") String query,
@JsonProperty("queryType") String queryType, @JsonProperty("autoLimit") String
autoLimit) {
+ public QueryWrapper(
+ @JsonProperty("query") String query,
+ @JsonProperty("queryType") String queryType,
+ @Nullable @JsonProperty("autoLimit") String autoLimit,
+ @Nullable @JsonProperty("userName") String userName) {
Review comment:
Please remove nullable annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Back button for failed query does not return on Query page
> -----------------------------------------------------------
>
> Key: DRILL-7203
> URL: https://issues.apache.org/jira/browse/DRILL-7203
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.16.0
> Reporter: Arina Ielchiieva
> Assignee: Dobes Vandermeer
> Priority: Major
> Attachments: back_button.JPG
>
>
> Back button for failed query returns on previous page before Query page but
> not on the Query page.
> Steps:
> 1. go to Logs page
> 2. go to Query page
> 3. execute query with incorrect syntax (ex: xxxxx)
> 4. error message will be displayed, Back button will be in left corner
> (screenshot attached)
> 5. press Back button
> 6. user is redirected to Logs page
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
