[
https://issues.apache.org/jira/browse/DRILL-7650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062556#comment-17062556
]
ASF GitHub Bot commented on DRILL-7650:
---------------------------------------
vvysotskyi commented on pull request #2031: DRILL-7650: Add option to enable
Jetty's dump for troubleshooting
URL: https://github.com/apache/drill/pull/2031#discussion_r395021565
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
##########
@@ -163,6 +163,7 @@ public void start() throws Exception {
embeddedJetty.addConnector(connector);
final boolean portHunt = config.getBoolean(ExecConstants.HTTP_PORT_HUNT);
+
embeddedJetty.setDumpAfterStart(config.getBoolean(ExecConstants.HTTP_JETTY_SERVER_DUMP_AFTER_START));
Review comment:
It is a minor comment. Placing it after declaring the `portHunt` variable
and before the loop where port hunting happens enforces to think that it should
be somehow connected with port hunting. Please move it above declaring the
`portHunt` variable if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add option to enable Jetty's dump for troubleshooting
> -----------------------------------------------------
>
> Key: DRILL-7650
> URL: https://issues.apache.org/jira/browse/DRILL-7650
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Reporter: Igor Guzenko
> Assignee: Igor Guzenko
> Priority: Minor
> Fix For: 1.18.0
>
>
> Jetty server implements a useful tool for
> [dumping|https://www.eclipse.org/jetty/documentation/current/jetty-dump-tool.html#dump-tool-via-jmx]
> the current state of the server, but in Drill, it's not possible to use it
> without code changes. This ticket aims to add option
> *drill.exec.http.jetty.server.dumpAfterStart* in Apache Drill.
> Another change is to remove the redundant setProtocol(protocol) method call
> on sslContextFactory instance.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
