[
https://issues.apache.org/jira/browse/DRILL-7641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068649#comment-17068649
]
ASF GitHub Bot commented on DRILL-7641:
---------------------------------------
arina-ielchiieva commented on pull request #2024: DRILL-7641 Convert Excel
Reader to use Streaming Reader
URL: https://github.com/apache/drill/pull/2024#discussion_r399236022
##########
File path:
contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java
##########
@@ -339,11 +339,12 @@ public void testInconsistentDataQuery() throws Exception
{
testBuilder()
.sqlQuery(sql)
- .ordered().baselineColumns("col1", "col2")
- .baselineValues("1.0", "Bob")
- .baselineValues("2.0", "Steve")
- .baselineValues("3.0", "Anne")
- .baselineValues("Bob", "3.0")
+ .ordered()
Review comment:
Your test does not include order by thus returned result order is
unpredictable. Please change to unordered here and in other tests above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Convert Excel Reader to Use Streaming Reader
> --------------------------------------------
>
> Key: DRILL-7641
> URL: https://issues.apache.org/jira/browse/DRILL-7641
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Text & CSV
> Affects Versions: 1.17.0
> Reporter: Charles Givre
> Assignee: Charles Givre
> Priority: Major
> Fix For: 1.18.0
>
>
> The current implementation of the Excel reader uses the Apache POI reader,
> which uses excessive amounts of memory. As a result, attempting to read large
> Excel files will cause out of memory errors.
> This PR converts the format plugin to use a streaming reader, based still on
> the POI library. The documentation for the streaming reader can be found
> here. [1]
> All unit tests pass and I tested the plugin with some large Excel files on my
> computer.
> [1]: [https://github.com/pjfanning/excel-streaming-reader]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
