[
https://issues.apache.org/jira/browse/DRILL-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072510#comment-17072510
]
ASF GitHub Bot commented on DRILL-7683:
---------------------------------------
arina-ielchiieva commented on issue #2045: DRILL-7683: Add "message parsing" to
new JSON loader
URL: https://github.com/apache/drill/pull/2045#issuecomment-607108696
+1, LGTM.
@paul-rogers let's for the future try to address comments without adding new
changes, here is were just a couple of files, in other PRs were much more, a
little hard for the code review to review new stuff with each commit :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add "message parsing" to new JSON loader
> ----------------------------------------
>
> Key: DRILL-7683
> URL: https://issues.apache.org/jira/browse/DRILL-7683
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.18.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Minor
> Fix For: 1.18.0
>
>
> Worked on a project that uses the new JSON loader to parse a REST response
> that includes a set of "wrapper" fields around the JSON payload. Example:
> {code:json}
> { "status": "ok", "results: [ data here ]}
> {code}
> To solve this cleanly, added the ability to specify a "message parser" to
> consume JSON tokens up to the start of the data. This parser can be written
> as needed for each different data source.
> Since this change adds one more parameter to the JSON structure parser, added
> builders to gather the needed parameters rather than making the constructor
> even larger.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
