[ 
https://issues.apache.org/jira/browse/DRILL-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072701#comment-17072701
 ] 

ASF GitHub Bot commented on DRILL-7678:
---------------------------------------

arina-ielchiieva commented on pull request #2044: DRILL-7678: Update Yauaa 
Dependency
URL: https://github.com/apache/drill/pull/2044#discussion_r401566246
 
 

 ##########
 File path: 
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
 ##########
 @@ -102,7 +102,7 @@ public void testEmptyFieldName() throws Exception {
   @Test
   public void testNullUserAgent() throws Exception {
     String query = "SELECT parse_user_agent(CAST(null as VARCHAR)) AS agent 
FROM (values(1))";
-    Map emptyMap = new HashMap();
+    Map<?, ?> emptyMap = new HashMap<>();
 
 Review comment:
   ```suggestion
       Map<?, ?> emptyMap = Collections.emptyMap();
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Update Yauaa dependency
> -----------------------
>
>                 Key: DRILL-7678
>                 URL: https://issues.apache.org/jira/browse/DRILL-7678
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Niels Basjes
>            Priority: Major
>
> The Yauaa useragent parsing library has a new release.
> Also a few changes and small optimizations are needed to make it work.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to