[
https://issues.apache.org/jira/browse/DRILL-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074309#comment-17074309
]
ASF GitHub Bot commented on DRILL-7437:
---------------------------------------
paul-rogers commented on pull request #1892: DRILL-7437: Storage Plugin for
Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r402761625
##########
File path:
contrib/storage-kudu/src/main/java/org/apache/drill/exec/store/kudu/KuduStoragePlugin.java
##########
@@ -35,15 +35,20 @@
private final KuduSchemaFactory schemaFactory;
private final KuduClient client;
-
public KuduStoragePlugin(KuduStoragePluginConfig configuration,
DrillbitContext context, String name)
- throws IOException {
+ throws IOException {
super(context, name);
this.schemaFactory = new KuduSchemaFactory(this, name);
this.engineConfig = configuration;
this.client = new
KuduClient.KuduClientBuilder(configuration.getMasterAddresses()).build();
}
+
+ @Override
+ public void start() throws IOException {
+
+ }
Review comment:
Is this change intentional? Or an artifact of rebasing? I suspect I removed
this method in some PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Storage Plugin for Generic HTTP REST API
> ----------------------------------------
>
> Key: DRILL-7437
> URL: https://issues.apache.org/jira/browse/DRILL-7437
> Project: Apache Drill
> Issue Type: New Feature
> Affects Versions: 1.17.0
> Reporter: Charles Givre
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> In many data analytic situations there is a need to obtain reference data
> which is volatile or hosted on a service with a REST API.
> For instance, consider the case of a financial dataset which you want to run
> a currency conversion. Or in the security arena, an organization might have
> a service that returns network information about an IT asset. The goal being
> to enable Drill to quickly incorporate external data that is only accessible
> via REST API.
> This plugin is not intended to be a substitute for dedicated storage plugins
> with systems that use a REST API, such as Apache Solr or ElasticSearch.
> This plugin is based on several projects that were posted on github but never
> completed or submitted to Drill. Posted here for attribution:
> * [https://github.com/kevinlynx/drill-storage-http]
> * [https://github.com/mayunSaicmotor/drill-storage-http]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
