[
https://issues.apache.org/jira/browse/DRILL-7745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142001#comment-17142001
]
ASF GitHub Bot commented on DRILL-7745:
---------------------------------------
vvysotskyi commented on a change in pull request #2084:
URL: https://github.com/apache/drill/pull/2084#discussion_r443526690
##########
File path: contrib/storage-ipfs/README.zh.md
##########
@@ -0,0 +1,184 @@
+# Drill Storage Plugin for IPFS
Review comment:
Please keep only `README.md` in English, since it would be problematic
to update it for other developers.
##########
File path:
contrib/storage-ipfs/src/main/java/org/apache/drill/exec/store/ipfs/IPFSContext.java
##########
@@ -0,0 +1,95 @@
+/*
+ * Copyright (c) 2018-2020 Bowen Ding, Yuedong Xu, Liang Wang
Review comment:
Please remove the custom license.
##########
File path: contrib/storage-ipfs/pom.xml
##########
@@ -0,0 +1,79 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <artifactId>drill-contrib-parent</artifactId>
+ <groupId>org.apache.drill.contrib</groupId>
+ <version>1.18.0-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>drill-ipfs-storage</artifactId>
+ <name>contrib/ipfs-storage-plugin</name>
+ <version>0.1.0</version>
+ <properties>
+ <ipfs.TestSuite>**/IPFSTestSuit.class</ipfs.TestSuite>
+ </properties>
+
+ <repositories>
Review comment:
Drill parent pom already has a jitpack repository, os there is no need
to duplicate it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add storage plugin for IPFS
> ---------------------------
>
> Key: DRILL-7745
> URL: https://issues.apache.org/jira/browse/DRILL-7745
> Project: Apache Drill
> Issue Type: New Feature
> Components: Storage - Other
> Affects Versions: 1.18.0
> Reporter: Bowen Ding
> Priority: Major
>
> See introduction here: [https://github.com/bdchain/Minerva]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
