[
https://issues.apache.org/jira/browse/DRILL-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150925#comment-17150925
]
ASF GitHub Bot commented on DRILL-7764:
---------------------------------------
sanel commented on a change in pull request #2093:
URL: https://github.com/apache/drill/pull/2093#discussion_r449513573
##########
File path: common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java
##########
@@ -73,7 +73,8 @@ private static void patchStopwatch() {
logger.info("Google's Stopwatch patched for old HBase Guava version.");
} catch (Exception e) {
- logger.warn("Unable to patch Guava classes.", e);
+ logger.warn("Unable to patch Guava classes: {}", e.getMessage());
Review comment:
These calls can be wrapped in a small static function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Cleanup warning messages in GuavaPatcher class
> ----------------------------------------------
>
> Key: DRILL-7764
> URL: https://issues.apache.org/jira/browse/DRILL-7764
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Minor
>
> Currently GuavaPatcher contains
> {code}
> logger.warn("Unable to patch Guava classes.", e);
> {code}
> which outputs whole exception stack trace to logs which is unnecessary
> alarming.
> This log message will be changed to
> {code}
> logger.warn("Unable to patch Guava classes: {}", e.getMessage());
> logger.debug("Exception:", e);
> {code}
> logging the stack trace only in debug mode.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
